PMD Results

The following document contains the results of PMD 4.2.2.

Files

org/springframework/osgi/compendium/internal/OsgiConfig.java

Violation Line
Avoid unused private fields such as 'log'. 232

org/springframework/osgi/config/BundleBeanDefinitionParser.java

Violation Line
Avoid unused method parameters such as 'parent'. 56 - 58

org/springframework/osgi/config/OsgiServiceLifecycleListenerAdapter.java

Violation Line
These nested if statements could be combined 104 - 105

org/springframework/osgi/config/OsgiServiceRegistrationListenerAdapter.java

Violation Line
These nested if statements could be combined 99 - 100
These nested if statements could be combined 142 - 144

org/springframework/osgi/config/ServiceBeanDefinitionParser.java

Violation Line
Avoid empty if statements 141
An empty statement (semicolon) not part of a loop 141
Avoid empty if statements 144
An empty statement (semicolon) not part of a loop 144
Avoid unused method parameters such as 'parent'. 191 - 206

org/springframework/osgi/context/internal/classloader/CachingAopClassLoaderFactory.java

Violation Line
Avoid empty catch blocks 49 - 51

org/springframework/osgi/context/internal/classloader/ChainedClassLoader.java

Violation Line
Avoid empty catch blocks 122 - 124

org/springframework/osgi/context/support/OsgiBundleXmlApplicationContext.java

Violation Line
Overriding method merely calls super 268 - 270

org/springframework/osgi/context/support/TrackingUtil.java

Violation Line
Avoid unused imports such as 'java.security.AccessControlContext' 23

org/springframework/osgi/service/exporter/support/AbstractOsgiServiceExporter.java

Violation Line
Avoid empty catch blocks 64 - 67

org/springframework/osgi/service/exporter/support/OsgiServiceFactoryBean.java

Violation Line
Avoid unused private fields such as 'controller'. 211

org/springframework/osgi/service/exporter/support/ServiceRegistrationDecorator.java

Violation Line
Avoid empty catch blocks 72 - 74

org/springframework/osgi/service/importer/DefaultOsgiServiceDependency.java

Violation Line
Avoid unused imports such as 'org.springframework.util.Assert' 20

org/springframework/osgi/service/importer/support/OsgiServiceCollectionProxyFactoryBean.java

Violation Line
Avoid unused private fields such as 'controller'. 152
Overriding method merely calls super 187 - 189

org/springframework/osgi/service/importer/support/OsgiServiceProxyFactoryBean.java

Violation Line
Avoid unused private fields such as 'controller'. 103
Overriding method merely calls super 136 - 138

org/springframework/osgi/service/importer/support/internal/aop/ServiceDynamicInterceptor.java

Violation Line
These nested if statements could be combined 176 - 180
These nested if statements could be combined 285 - 288

org/springframework/osgi/service/importer/support/internal/collection/DynamicList.java

Violation Line
Overriding method merely calls super 157 - 159

org/springframework/osgi/service/importer/support/internal/collection/OsgiServiceCollection.java

Violation Line
Avoid unused method parameters such as 'ppc'. 342 - 344

org/springframework/osgi/service/importer/support/internal/support/ServiceWrapper.java

Violation Line
Avoid empty finally blocks 101 - 103

org/springframework/osgi/service/util/internal/aop/ServiceTCCLInterceptor.java

Violation Line
Avoid unused imports such as 'org.springframework.osgi.util.internal.PrivilegedUtils.UnprivilegedThrowableExecution' 7

org/springframework/osgi/util/DebugUtils.java

Violation Line
Avoid unused private fields such as 'DOUBLE_QUOTE'. 55
Avoid unused private fields such as 'PACKAGE_PATTERN'. 63
These nested if statements could be combined 179 - 183
Avoid empty catch blocks 254 - 256
Avoid empty catch blocks 292 - 294
This for loop could be simplified to a while loop 325 - 330
Avoid unused local variables such as 'highEqualTo'. 381
Avoid unused local variables such as 'highLessThen'. 382
Avoid unused local variables such as 'right'. 390

org/springframework/osgi/util/OsgiListenerUtils.java

Violation Line
Avoid empty catch blocks 193 - 195

org/springframework/osgi/util/OsgiServiceReferenceUtils.java

Violation Line
Avoid unused private fields such as 'log'. 51

org/springframework/osgi/util/OsgiServiceUtils.java

Violation Line
Avoid empty catch blocks 45 - 46

org/springframework/osgi/util/internal/ClassUtils.java

Violation Line
Avoid empty while statements 382 - 383
These nested if statements could be combined 396 - 401
Avoid empty catch blocks 458 - 460

org/springframework/osgi/util/internal/PrivilegedUtils.java

Violation Line
Avoid returning from a finally block 92
Avoid returning from a finally block 134