The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Normal
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 763 | 21 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Should org.springframework.osgi.compendium.config.ManagedServiceDefinitionParser$UpdateStrategyAttributeCallback be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 48-63 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.context.internal.classloader.CachingAopClassLoaderFactory.createClassLoader(ClassLoader) creates a org.springframework.osgi.context.internal.classloader.ChainedClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 69 |
| org.springframework.osgi.context.internal.classloader.CachingAopClassLoaderFactory.createClassLoader(ClassLoader) creates a org.springframework.osgi.context.internal.classloader.ChainedClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 74 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.context.support.AbstractOsgiBundleApplicationContext.setConfigLocations(String[]) may expose internal representation by storing an externally mutable object into AbstractOsgiBundleApplicationContext.configLocations | MALICIOUS_CODE | EI_EXPOSE_REP2 | 176 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.service.exporter.support.OsgiServiceFactoryBean.setBeanClassLoader(ClassLoader) creates a org.springframework.osgi.context.internal.classloader.ChainedClassLoader classloader, which should be performed within a doPrivileged block | BAD_PRACTICE | DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED | 424 |
| org.springframework.osgi.service.exporter.support.OsgiServiceFactoryBean.getInterfaces() may expose internal representation by returning OsgiServiceFactoryBean.interfaces | MALICIOUS_CODE | EI_EXPOSE_REP | 619 |
| org.springframework.osgi.service.exporter.support.OsgiServiceFactoryBean.setInterfaces(Class[]) may expose internal representation by storing an externally mutable object into OsgiServiceFactoryBean.interfaces | MALICIOUS_CODE | EI_EXPOSE_REP2 | 629 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.service.importer.support.AbstractOsgiServiceImportFactoryBean.getInterfaces() may expose internal representation by returning AbstractOsgiServiceImportFactoryBean.interfaces | MALICIOUS_CODE | EI_EXPOSE_REP | 218 |
| org.springframework.osgi.service.importer.support.AbstractOsgiServiceImportFactoryBean.getListeners() may expose internal representation by returning AbstractOsgiServiceImportFactoryBean.listeners | MALICIOUS_CODE | EI_EXPOSE_REP | 236 |
| org.springframework.osgi.service.importer.support.AbstractOsgiServiceImportFactoryBean.setInterfaces(Class[]) may expose internal representation by storing an externally mutable object into AbstractOsgiServiceImportFactoryBean.interfaces | MALICIOUS_CODE | EI_EXPOSE_REP2 | 132 |
| org.springframework.osgi.service.importer.support.AbstractOsgiServiceImportFactoryBean.setListeners(OsgiServiceLifecycleListener[]) may expose internal representation by storing an externally mutable object into AbstractOsgiServiceImportFactoryBean.listeners | MALICIOUS_CODE | EI_EXPOSE_REP2 | 170 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.service.importer.support.ServiceReferenceDelegate defines compareTo(Object) and uses Object.equals() | BAD_PRACTICE | EQ_COMPARETO_USE_OBJECT_EQUALS | 71 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Invocation of toString on an array in org.springframework.osgi.service.importer.support.StaticServiceProxyCreator.discoverProxyClasses(ServiceReference) | CORRECTNESS | DMI_INVOKING_TOSTRING_ON_ARRAY | 142 |
| Bug | Category | Details | Line |
|---|---|---|---|
| The field org.springframework.osgi.service.importer.support.internal.aop.ImportedOsgiServiceProxyAdvice.reference is transient but isn't set by deserialization | BAD_PRACTICE | SE_TRANSIENT_FIELD_NOT_RESTORED | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.service.importer.support.internal.aop.ServiceDynamicInterceptor.getListeners() may expose internal representation by returning ServiceDynamicInterceptor.listeners | MALICIOUS_CODE | EI_EXPOSE_REP | 508 |
| org.springframework.osgi.service.importer.support.internal.aop.ServiceDynamicInterceptor.setListeners(OsgiServiceLifecycleListener[]) may expose internal representation by storing an externally mutable object into ServiceDynamicInterceptor.listeners | MALICIOUS_CODE | EI_EXPOSE_REP2 | 512 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Impossible cast from java.lang.IllegalAccessException to java.lang.RuntimeException in org.springframework.osgi.service.importer.support.internal.aop.ServiceInvoker.doInvoke(Object, MethodInvocation) | CORRECTNESS | BC_IMPOSSIBLE_CAST | 67 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.springframework.osgi.service.importer.support.internal.collection.OsgiServiceCollection.setListeners(OsgiServiceLifecycleListener[]) may expose internal representation by storing an externally mutable object into OsgiServiceCollection.listeners | MALICIOUS_CODE | EI_EXPOSE_REP2 | 450 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to highEqualTo in org.springframework.osgi.util.DebugUtils.getVersion(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 381 |
| Dead store to highLessThen in org.springframework.osgi.util.DebugUtils.getVersion(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 382 |
| Dead store to right in org.springframework.osgi.util.DebugUtils.getVersion(String, String) | STYLE | DLS_DEAD_LOCAL_STORE | 390 |
